New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple --ignore-path
flags
#6345
Conversation
🦋 Changeset detectedLatest commit: e181e37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimulaco Thanks for creating the pull request. I've left a comment about backward compatibility, so please confirm it.
--ignore-path
flag--ignore-path
flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Almost good. 👍🏼
I've left one more refactoring suggestion, so can you see it?
We may need to update the CLI help and the following documents about the Lines 125 to 129 in bb10282
stylelint/docs/user-guide/usage/cli.md Lines 59 to 61 in bb10282
stylelint/docs/user-guide/usage/options.md Lines 132 to 136 in bb10282
|
ESLint does a good job of this. Let's add "You can repeat the option to provide multiple paths" to those three descriptions, e.g. "Path to a file containing patterns that describe files to ignore. The path can be absolute or relative to process.cwd(). You can repeat the option to provide multiple paths. By default, Stylelint looks for .stylelintignore in process.cwd(). " |
@jeddy3 @ybiquitous Thanks. I have updated the document. 268f2af dc3db68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Closes #4680
No, it's self-explanatory.
Please let me know if I'm missing a unit test.