Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regex support for ignorePseudoElements option of selector-pseudo-element-no-unknown #6317

Merged
merged 2 commits into from Sep 3, 2022
Merged

Add regex support for ignorePseudoElements option of selector-pseudo-element-no-unknown #6317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfb1523
Add regex support for `ignorePseudoElements` option of `selector-pseu…
ybiquitous Sep 2, 2022
26de3c7
Add changelog entry
ybiquitous Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silver-baboons-dress.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"stylelint": minor
---

Added: regex support for `ignorePseudoElements` option of `selector-pseudo-element-no-unknown`
10 changes: 5 additions & 5 deletions lib/rules/selector-pseudo-element-no-unknown/README.md
View file
Open in desktop
Expand Up @@ -58,27 +58,27 @@ input::-moz-placeholder {}

## Optional secondary options

### `ignorePseudoElements: ["/regex/", "string"]`
### `ignorePseudoElements: ["/regex/", /regex/, "non-regex"]`

Given:

```json
["/^my-/", "pseudo-element"]
["/^--my-/", "--pseudo-element"]
```

The following patterns are _not_ considered problems:

<!-- prettier-ignore -->
```css
a::pseudo-element {}
a::--my-pseudo {}
```

<!-- prettier-ignore -->
```css
a::my-pseudo {}
a::--my-other-pseudo {}
```

<!-- prettier-ignore -->
```css
a::my-other-pseudo {}
a::--pseudo-element {}
```
5 changes: 4 additions & 1 deletion lib/rules/selector-pseudo-element-no-unknown/__tests__/index.js
View file
Open in desktop
Expand Up @@ -189,7 +189,7 @@ testRule({

testRule({
ruleName,
config: [true, { ignorePseudoElements: ['pseudo', '/^my-/'] }],
config: [true, { ignorePseudoElements: ['pseudo', '/^my-/', /foo/i] }],

accept: [
{
Expand All @@ -204,6 +204,9 @@ testRule({
{
code: 'a::my-pseudo { }',
},
{
code: 'a::FOO-pseudo { }',
},
],

reject: [
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/selector-pseudo-element-no-unknown/index.js
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ const report = require('../../utils/report');
const ruleMessages = require('../../utils/ruleMessages');
const validateOptions = require('../../utils/validateOptions');
const vendor = require('../../utils/vendor');
const { isString } = require('../../utils/validateTypes');
const { isString, isRegExp } = require('../../utils/validateTypes');

const ruleName = 'selector-pseudo-element-no-unknown';

Expand All @@ -31,7 +31,7 @@ const rule = (primary, secondaryOptions) => {
{
actual: secondaryOptions,
possible: {
ignorePseudoElements: [isString],
ignorePseudoElements: [isString, isRegExp],
},
optional: true,
},
Expand Down