Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negatives for SVG properties in alpha-value-notation #6284

Merged
merged 1 commit into from Aug 21, 2022

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Aug 18, 2022

Which issue, if any, is this issue related to?

see stylelint/stylelint-config-standard#257

Is there anything in the PR that needs further explanation?

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022

⚠️ No Changeset found

Latest commit: fd3d454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Mouvedia
Copy link
Contributor Author

Mouvedia commented Aug 18, 2022

Dunno if its changeset's fault but we have a "Startup failure" on the PR checks.

@jeddy3 jeddy3 changed the title fix: add support for SVG properties to alpha-value-notation Fix false negatives for SVG properties in alpha-value-notation Aug 18, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

We don't need to merge this before the next release if we want to keep the new changeset workflow trial simple as this pull request requires a new release of the standard config.

(It'll be a "minor" changeset entry if we follow our semver policy.)

ybiquitous
ybiquitous previously approved these changes Aug 21, 2022
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mouvedia Thank you. LGTM 👍🏼

@ybiquitous ybiquitous dismissed their stale review August 21, 2022 02:27

Blocking merge now

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll use the existing workflow in the next release (see #6287), so we can merge this PR.

@ybiquitous ybiquitous merged commit 791cb34 into stylelint:main Aug 21, 2022
@ybiquitous
Copy link
Member

Changelog entry added:

  • Fixed: alpha-value-notation false negatives for SVG properties (#6284).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants