Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce changesets for CHANGELOG auto-generation #6274

Merged
merged 9 commits into from Aug 18, 2022
Merged

Introduce changesets for CHANGELOG auto-generation #6274

merged 9 commits into from Aug 18, 2022

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Aug 17, 2022

Which issue, if any, is this issue related to?

Related #6253

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@JounQin JounQin added the type: infrastructure an improvement to devops label Aug 17, 2022
@JounQin JounQin self-assigned this Aug 17, 2022
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022 •
edited

🦋 Changeset detected

Latest commit: bf6bdef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ybiquitous
ybiquitous reviewed Aug 17, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ybiquitous ybiquitous removed the type: infrastructure an improvement to devops label Aug 17, 2022
ybiquitous
ybiquitous reviewed Aug 17, 2022
View reviewed changes
.changeset/config.json Outdated Show resolved Hide resolved
@ybiquitous ybiquitous changed the title ci: enable changesets for CHANGELOG only Introduce changesets for CHANGELOG auto-generation Aug 17, 2022
ybiquitous
ybiquitous requested changes Aug 17, 2022
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@JounQin
Copy link
Member Author

JounQin commented Aug 17, 2022

I'm going to migrate current HEAD changelog into changesets in this PR, HDYT? @ybiquitous

ybiquitous
ybiquitous reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JounQin Thank you. I've left some comments, but it seems there are no problems.

.changeset/changelog-stylelint.js Outdated Show resolved Hide resolved
.github/workflows/releasing.yml Show resolved Hide resolved
@ybiquitous
Copy link
Member

[Remind] If this new workflow fits, we'll need to update the maintainer guide after this PR is merged:

  • stylelint/docs/maintainer-guide/pull-requests.md

    Line 27 in 613334b

    2. Update the [changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) directly via the [GitHub website](https://github.com/stylelint/stylelint/edit/main/CHANGELOG.md) for everything except refactoring and documentation changes:

  • stylelint/docs/maintainer-guide/releases.md

    Lines 8 to 9 in 613334b

    1. [Consistently format](pull-requests.md) the [changelog](../../CHANGELOG.md).
    2. Replace `## Head` with new version number e.g. `## 8.1.2`.

ybiquitous
ybiquitous previously approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to move forward with the evaluation of new workflow, so LGTM 👍🏼

@JounQin
Copy link
Member Author

JounQin commented Aug 17, 2022 •
edited

I'll wait for one more day to see if there will be any new reviews, then I'm going to merge. 🍺

Just found I haven't finished this part: #6274 (comment)

cc @ybiquitous

@ybiquitous ybiquitous dismissed their stale review August 18, 2022 00:03

Not completed

@ybiquitous
Copy link
Member

Just found I haven't finished this part: #6274 (comment)

Sorry, I missed it. Can you push the change into this branch, please?

@JounQin
Copy link
Member Author

JounQin commented Aug 18, 2022

Just found I haven't finished this part: #6274 (comment)

Sorry, I missed it. Can you push the change into this branch, please?

Sure, I'd like to finish them today.

jeddy3
jeddy3 reviewed Aug 18, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Let's adopt the ESLint format for mentions because it's simple and more in line with the existing format of the changelog.

For example:

@JounQin JounQin requested a review from jeddy3 August 18, 2022 09:26
@ybiquitous ybiquitous mentioned this pull request Aug 18, 2022
Closed
6 tasks
@ybiquitous
Copy link
Member

Ah, sorry. I've updated the changelog for #6275, and conflicts occur. Could you please resolve the conflicts? @JounQin

@JounQin
Copy link
Member Author

JounQin commented Aug 18, 2022 •
edited

Ah, sorry. I've updated the changelog for #6275, and conflicts occur. Could you please resolve the conflicts? @JounQin

Sure, wait a minute.

@ybiquitous Done!

JounQin and others added 8 commits August 18, 2022 17:52
@JounQin
ci: enable changesets for CHANGELOG only
7c6652a
@JounQin @ybiquitous
Update .github/workflows/release.yml
022d7e4 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@JounQin @ybiquitous
Update .github/workflows/release.yml
88b05b1 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@JounQin @ybiquitous
Update .github/workflows/release.yml
067028f 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@JounQin @ybiquitous
Update .github/workflows/release.yml
fea2427 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@JounQin
ci: fix lint test
aa73288
@JounQin
chore: use custom changelog-stylelint
8e97e92
@JounQin
docs: extract HEAD changelogs into changesets files
629c96d
ybiquitous
ybiquitous approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍🏼

@JounQin
Copy link
Member Author

JounQin commented Aug 18, 2022

@jeddy3 Are we good to merge right now?

jeddy3
jeddy3 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@JounQin JounQin merged commit aff9a8e into main Aug 18, 2022
@JounQin JounQin deleted the chore/changesets branch August 18, 2022 11:18
@JounQin
Copy link
Member Author

JounQin commented Aug 18, 2022 •
edited

https://github.com/stylelint/stylelint/runs/7897522989?check_suite_focus=true#step:6:61

@ybiquitous @jeddy3 It seems the permissions are not working as expected, would you like to help?

Please help to review #6281

@JounQin JounQin mentioned this pull request Aug 18, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 18, 2022
Closed
@ybiquitous ybiquitous mentioned this pull request Aug 18, 2022
Merged
@jeddy3 jeddy3 mentioned this pull request Aug 18, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

@hudochenkov hudochenkov Awaiting requested review from hudochenkov

Assignees

@JounQin JounQin

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JounQin @ybiquitous @jeddy3