New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for interpolation in keyframes-name-pattern #6265
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a99d195
Add `isStandardSyntaxKeyframesName` utility
a-sokolova-dev e428746
Update `keyframes-name-pattern` rule
a-sokolova-dev 657352d
Pull Request Review Fixes
a-sokolova-dev 685ba22
Fix function naming and jest matchers
a-sokolova-dev 8d2fd35
Minor tests change
a-sokolova-dev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
'use strict'; | ||
|
||
const isStandardSyntaxKeyframesName = require('../isStandardSyntaxKeyframesName'); | ||
|
||
describe('isStandardSyntaxKeyframesName', () => { | ||
it('standard name', () => { | ||
expect(isStandardSyntaxKeyframesName('slidein {}')).toBe(true); | ||
}); | ||
it('hyphenated name', () => { | ||
expect(isStandardSyntaxKeyframesName('slide-in {}')).toBe(true); | ||
}); | ||
it('name with underscore', () => { | ||
expect(isStandardSyntaxKeyframesName('slide_in {}')).toBe(true); | ||
}); | ||
it('scss interpolation', () => { | ||
expect(isStandardSyntaxKeyframesName('frame-#{$name} {}')).toBe(false); | ||
}); | ||
it('scss interpolation start', () => { | ||
expect(isStandardSyntaxKeyframesName('#{$name}-frame {}')).toBe(false); | ||
}); | ||
it('scss interpolation single quoted', () => { | ||
expect(isStandardSyntaxKeyframesName("'frame-#{$name}' {}")).toBe(false); | ||
}); | ||
it('scss interpolation single quoted start', () => { | ||
expect(isStandardSyntaxKeyframesName("'#{$name}-frame' {}")).toBe(false); | ||
}); | ||
it('scss interpolation double quoted', () => { | ||
expect(isStandardSyntaxKeyframesName('"frame-#{$name}" {}')).toBe(false); | ||
}); | ||
it('scss interpolation doubled quoted start', () => { | ||
expect(isStandardSyntaxKeyframesName('"#{$name}-frame" {}')).toBe(false); | ||
}); | ||
it('less interpolation', () => { | ||
expect(isStandardSyntaxKeyframesName('frame-@{name} {}')).toBe(false); | ||
}); | ||
it('less interpolation start', () => { | ||
expect(isStandardSyntaxKeyframesName('@{name}-frame {}')).toBe(false); | ||
}); | ||
it('less interpolation single quoted', () => { | ||
expect(isStandardSyntaxKeyframesName("'frame-@{name}' {}")).toBe(false); | ||
}); | ||
it('less interpolation single quoted start', () => { | ||
expect(isStandardSyntaxKeyframesName("'@{name}-frame {}' {}")).toBe(false); | ||
}); | ||
it('less interpolation double quoted', () => { | ||
expect(isStandardSyntaxKeyframesName('"frame-@{name}" {}')).toBe(false); | ||
}); | ||
it('less interpolation doubled quoted start', () => { | ||
expect(isStandardSyntaxKeyframesName('"@{name}-frame" {}')).toBe(false); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
'use strict'; | ||
|
||
const hasInterpolation = require('./hasInterpolation'); | ||
|
||
/** | ||
* Check whether a keyframes name is standard | ||
* | ||
* @param {string} keyframesName | ||
* @returns {boolean} | ||
*/ | ||
module.exports = function isStandardSyntaxKeyframesName(keyframesName) { | ||
if (hasInterpolation(keyframesName)) { | ||
return false; | ||
} | ||
|
||
return true; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're only testing the name, not the block. We'll need to remove the block from the other tests too.