Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-pseudo-element-colon-notation end positions #6235

Merged

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Part of #5694

Is there anything in the PR that needs further explanation?

Chose to just highlight the colons; let me know if we should highlight the entire pseudo-element instead!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chose to just highlight the colons

No problems. LGTM 👍🏼

@mattxwang mattxwang changed the title Fix end positions for selector-pseudo-element-colon-notation Fix selector-pseudo-element-colon-notation end positions Jul 28, 2022
@mattxwang mattxwang merged commit 4d8b28e into main Jul 28, 2022
@mattxwang mattxwang deleted the fix-end-position-selector-pseudo-element-colon-notation branch July 28, 2022 23:47
@mattxwang
Copy link
Member Author

Oops - realized I can't edit CHANGELOG.md, should have waited. @ybiquitous do you mind writing in the changelog entry?

@ybiquitous
Copy link
Member

Done!

  • Fixed: selector-pseudo-element-colon-notation end positions (#6235).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants