Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-attribute-quotes end positions #6226

Merged
merged 1 commit into from Jul 28, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #5694

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

function complain(message, index) {
function complain(message, attrNode) {
const index = attrNode.sourceIndex + attrNode.offsetOf('value');
const value = attrNode.raws.value || attrNode.value || '';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] .raws.value can include quote marks like '.

@ybiquitous ybiquitous marked this pull request as ready for review July 27, 2022 15:43
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@ybiquitous ybiquitous merged commit f02ee48 into main Jul 28, 2022
@ybiquitous ybiquitous deleted the fix-selector-attribute-quotes-end-pos branch July 28, 2022 08:58
@ybiquitous
Copy link
Member Author

Changelog entry added:

  • Fixed: selector-attribute-quotes end positions (#6226).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants