Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percentage-unless-within-keyword-only-block primary option to keyframe-selector-notation #6194

Merged
merged 2 commits into from Jul 6, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6191

Is there anything in the PR that needs further explanation?

It's necessary to call .walkRules() twice to get all selectors in a @keyframes block. In most cases, I don't believe there will not pay a performance penalty.

@ybiquitous ybiquitous marked this pull request as ready for review July 5, 2022 14:32
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

LGTM.

@ybiquitous ybiquitous merged commit b52b8ca into main Jul 6, 2022
@ybiquitous ybiquitous deleted the issue-6191 branch July 6, 2022 14:04
@ybiquitous
Copy link
Member Author

@jeddy3 Thanks! Changelog entry added:

  • Added: percentage-unless-within-keyword-only-block primary option to keyframe-selector-notation (#6194).

@ybiquitous
Copy link
Member Author

Oh, keyframe-selector-notation is not published. Is the entry unnecessary?

@jeddy3
Copy link
Member

jeddy3 commented Jul 7, 2022

I think it's fine to leave in so people can find the PR that adds the option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add percentage-unless-within-keyword-only-block primary option to keyframe-selector-notation
2 participants