Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reference data into groups #6179

Merged
merged 12 commits into from
Jun 28, 2022
Merged

Refactor reference data into groups #6179

merged 12 commits into from
Jun 28, 2022

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Jun 27, 2022

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

This pull request doesn't add any new reference data to the public API as we'll only want to do that if it's requested because we'll need to make sure the set names are accurate to the specs. What it does is:

  • breaks up the unwieldy keywordSet.js file into more accurately named groups
  • uses the destructuring convention from Add shorthand properties reference to public API #6168 to make it clear what data a rule or util is using
  • standardizes a few of the set names, e.g. everything in keywords is a *Keywords set

Hopefully, this will make the reference data easier to work with internally and better prepare it for being added to the public API when requested.

@jeddy3 jeddy3 changed the title Refactor reference data Refactor reference data into groups Jun 27, 2022
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! I've left trivial suggestions, but it looks good enough to merge. 👍🏼

lib/utils/isMathFunction.js Outdated Show resolved Hide resolved
lib/utils/uniteSets.js Outdated Show resolved Hide resolved
jeddy3 and others added 2 commits June 28, 2022 11:42
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 jeddy3 merged commit 12f1141 into main Jun 28, 2022
@jeddy3 jeddy3 deleted the refactor-reference-data branch June 28, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants