Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyframe-selector-notation #6164

Merged
merged 7 commits into from Jun 23, 2022
Merged

Add keyframe-selector-notation #6164

merged 7 commits into from Jun 23, 2022

Commits on Jun 20, 2022

  1. Add keyframe-selector-notation

    @mattxwang
    mattxwang committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    4a4803f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Apply suggestions from code review 

    Typo fixes and type hints

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    357eedb View commit details
    Browse the repository at this point in the history

  2. Refactor to use simplified objects, types, and sets. 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    0d37718 View commit details
    Browse the repository at this point in the history

  3. Typo fix - 0 -> 0% 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    a3f5180 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Apply suggestions from code review 

    Minor naming fix, remove unnecessary description

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    8a4000e View commit details
    Browse the repository at this point in the history

  2. adds edge case tests, fixes bug for selector lists

    @mattxwang
    mattxwang committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    aba9ae4 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Implements suggested refactor to use transformSelector 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    f24bce3 View commit details
    Browse the repository at this point in the history