Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation-no-unknown #6155

Merged
merged 8 commits into from
Jun 21, 2022
Merged

Add annotation-no-unknown #6155

merged 8 commits into from
Jun 21, 2022

Commits on Jun 19, 2022

  1. Add annotation-no-unknown 

    Possible questions with my implementation:
- how should I be checking for nonstandard syntax?
  ex just at the declaration level?
- I've interpreted the spec to allow any capitalization of important,
  but I could be wrong here! I did test on Chrome and it seems to allow
  case-insensitive responses.
- I've opted to include the `!` in the secondary options; is that too
  clunky?
- should I add any testcases for nonstandard syntax?
    @mattxwang
    mattxwang committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    1fa8892 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. update annotation-no-unknown description 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    c0f8e7f View commit details
    Browse the repository at this point in the history

  2. fix typo 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    426bc2f View commit details
    Browse the repository at this point in the history

  3. remove unnecessary examples 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    b44cfd2 View commit details
    Browse the repository at this point in the history

  4. fix typo 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @mattxwang @jeddy3
    mattxwang and jeddy3 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    c487dfc View commit details
    Browse the repository at this point in the history

  5. removes new keywordSets, updates rule position in list

    @mattxwang
    mattxwang committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    014d7c7 View commit details
    Browse the repository at this point in the history

  6. use dashed idents, don't require '!'

    @mattxwang
    mattxwang committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    a5e8d51 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. adds explicit check for decl.important 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @mattxwang @ybiquitous
    mattxwang and ybiquitous committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    4432aaa View commit details
    Browse the repository at this point in the history