Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tally to string and verbose formatters #6153

Merged
merged 2 commits into from Jun 20, 2022
Merged

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Jun 15, 2022

Which issue, if any, is this issue related to?

Closes #5590

Is there anything in the PR that needs further explanation?

Demo:

$ cd scripts
$ ./visual.sh
Normal:

visual.css
 2:9  ✖  Unexpected invalid hex color "#4f"                color-no-invalid-hex   
 4:1  ✖  Expected ".foo.bar" to have no more than 1 class  selector-max-class     
 5:8  ✖  Unexpected unit "px"                              unit-disallowed-list   
 6:3  ⚠  Expected custom property name to be kebab-case    custom-property-pattern

4 problems (3 errors, 1 warning)



Verbose:

visual.css
 2:9  ✖  Unexpected invalid hex color "#4f"                color-no-invalid-hex   
 4:1  ✖  Expected ".foo.bar" to have no more than 1 class  selector-max-class     
 5:8  ✖  Unexpected unit "px"                              unit-disallowed-list   
 6:3  ⚠  Expected custom property name to be kebab-case    custom-property-pattern

4 problems (3 errors, 1 warning)

1 source checked
 /Users/koba/git/stylelint/stylelint/scripts/visual.css

3 errors found
 color-no-invalid-hex: 1
 selector-max-class: 1
 unit-disallowed-list: 1

1 warning found
 custom-property-pattern: 1
Screenshot image

@ybiquitous ybiquitous marked this pull request as ready for review June 15, 2022 14:29
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! A nice addition.

LGTM.

@ybiquitous ybiquitous merged commit 15a5b5b into main Jun 20, 2022
@ybiquitous ybiquitous deleted the add-tally-to-formatters branch June 20, 2022 10:19
@ybiquitous
Copy link
Member Author

Thank you for the review!

Changelog entry added:

  • Added: tally to string and verbose formatters (#6153).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add tally to string formatter
2 participants