Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to remove callbacks in test examples #6149

Merged
merged 2 commits into from Jun 20, 2022
Merged

Refactor to remove callbacks in test examples #6149

merged 2 commits into from Jun 20, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Jun 14, 2022 •
edited

Which issue, if any, is this issue related to?

Closes #4881

Is there anything in the PR that needs further explanation?

I had completely forgotten to work on #4881. 馃槄
This pull request should be the last.

$ git grep  -E '\.(then|catch|finally)' '**/*.test.js' || echo 'no match'
no match

Recommended view: files?w=1

@ybiquitous
Refactor to remove callbacks in test examples
8e988eb 
```console
$ git grep  -E '\.(then|catch|finally)' '**/*.test.js' || echo 'no match'
no match
```
@ybiquitous ybiquitous marked this pull request as ready for review June 14, 2022 13:49
jeddy3
jeddy3 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM, thank you.

@ybiquitous
Copy link
Member Author

@jeddy3 Thank you. 馃槃

@ybiquitous ybiquitous merged commit f67ec4e into main Jun 20, 2022
@ybiquitous ybiquitous deleted the remove-callbacks-in-test-examples branch June 20, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests that use callbacks
2 participants
@ybiquitous @jeddy3