You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there anything in the PR that needs further explanation?
This PR contains end positions for:
declaration-block-no-duplicate-custom-properties
declaration-block-no-duplicate-properties
declaration-block-no-shorthand-property-overrides
These are all of the rules matching declaration-block-no-* in the "Avoid Errors" section.
I don't mind adding support for declaration-block-no-redundant-longhand-properties as well (in "Enforce conventions"), though I'm a bit confused about how I would implement the start/end positions for this; what should I be highlighting? The actual shorthand (ex margin) doesn't appear in the code itself. Would I highlight each of the longhand properties separately?
Also, I manually did all the test cases included, though some double-checking for some of them would be nice! Pretty confident that they work as intended.
I don't mind adding support for declaration-block-no-redundant-longhand-properties as well (in "Enforce conventions"), though I'm a bit confused about how I would implement the start/end positions for this; what should I be highlighting? The actual shorthand (ex margin) doesn't appear in the code itself. Would I highlight each of the longhand properties separately?
IMO, it's good to follow the current behavior. Currently, the rule warns at the start column of the last property (margin-left in the demo below), so it seems good that the end column also follows the last property. Any thoughts?
IMO, it's good to follow the current behavior. Currently, the rule warns at the start column of the last property (margin-left in the demo below), so it seems good that the end column also follows the last property. Any thoughts?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the umbrella issue #5694.
This PR contains end positions for:
declaration-block-no-duplicate-custom-propertiesdeclaration-block-no-duplicate-propertiesdeclaration-block-no-shorthand-property-overridesThese are all of the rules matching
declaration-block-no-*in the "Avoid Errors" section.I don't mind adding support for
declaration-block-no-redundant-longhand-propertiesas well (in "Enforce conventions"), though I'm a bit confused about how I would implement the start/end positions for this; what should I be highlighting? The actual shorthand (exmargin) doesn't appear in the code itself. Would I highlight each of the longhand properties separately?Also, I manually did all the test cases included, though some double-checking for some of them would be nice! Pretty confident that they work as intended.