New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyframe-block-no-duplicate-selectors
#6024
Conversation
For code coverage - is there a specific way I should be testing the rule with invalid options? That's the only uncovered line I have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang Thanks for creating the pull request. 👍🏼
Additionally, it should be better to support end positions for warnings.
See also #5694 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang Thank you! Looking good so far.
As @ybiquitous said, we'll want to add column and line numbers (including end ones) to the reject tests.
I've requested a few changes myself.
Yes. Let's add
They're comprehensive enough, thank you.
Yes, LGTM.
You can ignore the coverage warning. |
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Thank you @jeddy3 and @ybiquitous for the in-depth feedback - end positions and non-standard syntax slipped my mind! I've pushed changes to address the feedback; let me know if you have any other thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang Nice! LGTM 👍🏼
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang Thanks for making the changes. LGTM.
|
Closes #5991.
Still newish to the overall codebase! A couple of questions I had (and of course, general feedback is much appreciated):