Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "empty functions" to commonly overlooked edge cases #6023

Merged
merged 1 commit into from Apr 18, 2022
Merged

Add "empty functions" to commonly overlooked edge cases #6023

merged 1 commit into from Apr 18, 2022

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

A follow-up to #5972 and #5982. From the former:

Follow-up PR to add "empty functions" to commonly overlooked edge cases.

Is there anything in the PR that needs further explanation?

N/A - pretty trivial. Let me know if a different example/location is preferred.

jeddy3
jeddy3 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeddy3 jeddy3 merged commit a04eb0d into main Apr 18, 2022
@jeddy3 jeddy3 deleted the docs-empty-functions-overlooked-edge-cases branch April 18, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattxwang @jeddy3