Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for large/small/dynamic viewport units in unit-no-unknown #5970

Merged
merged 1 commit into from Mar 18, 2022
Merged

Fix false positives for large/small/dynamic viewport units in unit-no-unknown #5970

merged 1 commit into from Mar 18, 2022

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Mar 16, 2022 •
edited

Which issue, if any, is this issue related to?

@jeddy3 jeddy3 changed the title Fix false negatives for unit-no-unknown and selector-type-case Fix false positives for dynamic viewport units in unit-no-unknown Mar 17, 2022
jeddy3
jeddy3 requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.

Let's pull the changes for the case rule into a separate pull request.

@Mouvedia Mouvedia changed the title Fix false positives for dynamic viewport units in unit-no-unknown Fix false positives for large/small/dynamic viewport units in unit-no-unknown Mar 17, 2022
@Mouvedia Mouvedia mentioned this pull request Mar 17, 2022
Merged
@Mouvedia Mouvedia changed the title Fix false positives for large/small/dynamic viewport units in unit-no-unknown Fix false negatives for large/small/dynamic viewport units in unit-no-unknown Mar 17, 2022
@Mouvedia Mouvedia requested a review from jeddy3 March 17, 2022 19:22
@jeddy3 jeddy3 changed the title Fix false negatives for large/small/dynamic viewport units in unit-no-unknown Fix false positives for large/small/dynamic viewport units in unit-no-unknown Mar 17, 2022
jeddy3
jeddy3 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling the changes out.

LGTM.

It fixes positives rather than negatives. See demo.

@Mouvedia
Copy link
Contributor Author

Mouvedia commented Mar 17, 2022 •
edited

It fixes positives rather than negatives. See demo.

Reading the definition, It seemed like false negatives to me. It probably depends on your referential.

ybiquitous
ybiquitous approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mouvedia Thank you. LGTM 👍🏼

@jeddy3 jeddy3 merged commit a304675 into stylelint:main Mar 18, 2022
@jeddy3
Copy link
Member

jeddy3 commented Mar 18, 2022

  • Fixed: unit-no-unknown false positives for large/small/dynamic viewport units (#5970).

@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false negatives for missing viewport units in unit-no-unknown
3 participants
@Mouvedia @jeddy3 @ybiquitous