Fix false positives/negatives in selector-pseudo-class/element-no-unknown #5959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mouvedia
commented
Mar 11, 2022
| @@ -244,16 +295,17 @@ keywordSets.otherPseudoClasses = new Set([ | |||
| 'first-child', | |||
| 'first-of-type', | |||
| 'focus', | |||
| 'focus-ring', | |||
There was a problem hiding this comment.
from an old draft
cf https://caniuse.com/css-focus-visible
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
from
88c3797
to
4a25c72
Compare
Mouvedia
commented
Mar 11, 2022
| // TODO migrate to vendorSpecificPseudoClasses | ||
| // see #2264 | ||
| keywordSets.webkitProprietaryPseudoClasses = new Set([ | ||
| // https://webkit.org/blog/363/styling-scrollbars/ |
There was a problem hiding this comment.
this source was the cause of the typo
Mouvedia
commented
Mar 11, 2022
| 'valid', | ||
| 'visited', | ||
| 'window-inactive', // for ::selection (chrome) |
There was a problem hiding this comment.
also in webkitScrollbarPseudoClasses
strictly speaking, the one at l381 is not necessary anymore
but it's better that way (less brittle to refactoring)
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
from
4a25c72
to
186dc1e
Compare
Mouvedia
commented
Mar 11, 2022
| 'focus-within', | ||
| 'focus-visible', | ||
| 'fullscreen', | ||
| 'fullscreen-ancestor', |
There was a problem hiding this comment.
supported by Opera 12
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
from
186dc1e
to
b22a16c
Compare
Mouvedia
commented
Mar 11, 2022
| @@ -238,22 +289,22 @@ keywordSets.otherPseudoClasses = new Set([ | |||
| 'default', | |||
| 'defined', | |||
| 'disabled', | |||
| 'drop', | |||
There was a problem hiding this comment.
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
from
b22a16c
to
b3e34dc
Compare
|
There are many more that are missing but Ill stop here; the PR has to be reviewable. |
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
3 times, most recently
from
7d74bc5
to
c7a2309
Compare
Mouvedia
changed the title
Mouvedia
changed the title
Mouvedia
changed the title
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
3 times, most recently
from
5dc6331
to
e5805bd
Compare
Mouvedia
commented
Mar 12, 2022
| @@ -164,12 +167,6 @@ testRule({ | |||
| line: 2, | |||
| column: 9, | |||
| }, | |||
| { | |||
| code: '::-webkit-unknown:window-inactive { }', | |||
There was a problem hiding this comment.
If it detected unknown pseudo elements, it would now correctly reject ::-webkit-unknown.
That's not what we are testing though.
Mouvedia
changed the title
Mouvedia
changed the title
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
from
e5805bd
to
89cac56
Compare
jeddy3
requested changes
Mar 14, 2022
This comment was marked as resolved.
This comment was marked as resolved.
ybiquitous
reviewed
Mar 15, 2022
…nown add ::cue, ::target-text, :unresolved, :picture-in-picture, :window-inactive, :fullscreen-ancestor, etc. remove :focus-ring, :drop typo ::-webkit-resizer https://hg.mozilla.org/mozilla-central/file/tip/layout/style/test/test_non_content_accessible_pseudos.html#l8 https://hg.mozilla.org/mozilla-central/file/tip/layout/style/test/test_selectors.html#l1102 https://trac.webkit.org/changeset/252330/webkit/ keywords: datetime, meter, search, validation, any, drag
Mouvedia
force-pushed
the
mouvedia-pseudo
branch
from
89cac56
to
83f7fa2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup of #5956
see #5956 (comment)
#2264
Ill add comments on the relevant lines.
Remember to check the commit's message.