Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clarity of invalid option warning message for objects #5923

Merged
merged 1 commit into from Feb 20, 2022
Merged

Fix clarity of invalid option warning message for objects #5923

merged 1 commit into from Feb 20, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Feb 20, 2022 •
edited

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

When an object is embedded into a message, it's not user-friendly. E.g.

Invalid option value "[object Object]" for rule "foo"

@ybiquitous ybiquitous marked this pull request as ready for review February 20, 2022 16:32
@jeddy3 jeddy3 changed the title Improve messages by validateOptions() Fix clarity of invalid option warning message for objects Feb 20, 2022
jeddy3
jeddy3 approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@ybiquitous
Copy link
Member Author

@jeddy3 Thanks for the review. Should we update the changelog?

@jeddy3
Copy link
Member

jeddy3 commented Feb 20, 2022

Should we update the changelog?

Yeap, something along the lines of:

  • Fixed: clarity of invalid option warning message for objects

@ybiquitous ybiquitous merged commit e870430 into main Feb 20, 2022
@ybiquitous ybiquitous deleted the fix-validateOptions-message branch February 20, 2022 17:24
@ybiquitous
Copy link
Member Author

Thank you. Updated. 👍🏼

  • Fixed: clarity of invalid option warning message for objects (#5923).

@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3