New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignoreFunctions
option to function-no-unknown
#5901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting started on this so quickly!
I've made two suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@jeddy3 I have no left for this pull request. Can we merge this? |
@ybiquitous Yes, go ahead. I've changed the branch protection rules to require one approval. It's a more sensible default. We can reserve two reviews for only the larger pull requests (e.g. adding a new rule). |
Thank you! |
|
Sorry. I forgot to update the changelog... 😓 |
No worries! I've done that loads of times before 😅 |
Closes #5900
No, it's self-explanatory.