Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for meta.url to enable links in terminal #5845

Merged
merged 5 commits into from
Jan 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/developer-guide/plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ We recommend your plugin adheres to [Stylelint's conventions](rules.md) for:
- messages
- tests
- docs
- metadata

## The anatomy of a plugin

Expand All @@ -20,6 +21,10 @@ const ruleName = "plugin/foo-bar";
const messages = stylelint.utils.ruleMessages(ruleName, {
expected: "Expected ..."
});
const meta = {
url: "https://github.com/foo-org/stylelint-foo/blob/main/src/rules/foo-bar/README.md"
// deprecated: true,
};

module.exports = stylelint.createPlugin(
ruleName,
Expand Down Expand Up @@ -47,6 +52,7 @@ module.exports = stylelint.createPlugin(

module.exports.ruleName = ruleName;
module.exports.messages = messages;
module.exports.meta = meta;
```

Your plugin's rule name must be namespaced, e.g. `your-namespace/your-rule-name`, to ensure it never clashes with the built-in rules. If your plugin provides only a single rule or you can't think of a good namespace, you can use `plugin/my-rule`. _You should document your plugin's rule name (and namespace) because users need to use them in their config._
Expand Down Expand Up @@ -79,6 +85,9 @@ const ruleName = "plugin/foo-bar-async";
const messages = stylelint.utils.ruleMessages(ruleName, {
expected: "Expected ..."
});
const meta = {
/* .. */
};

module.exports = stylelint.createPlugin(
ruleName,
Expand Down Expand Up @@ -112,6 +121,7 @@ module.exports = stylelint.createPlugin(

module.exports.ruleName = ruleName;
module.exports.messages = messages;
module.exports.meta = meta;
```

## Testing
Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide/rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ You should:
Deprecating rules doesn't happen very often. When you do, you must:

1. Point the `stylelintReference` link to the specific version of the rule README on the GitHub website, so that it is always accessible.
2. Add the appropriate meta data to mark the rule as deprecated.
2. Add the appropriate metadata to mark the rule as deprecated like `rule.meta = { deprecated: true }`.

## Improve the performance of a rule

Expand Down
12 changes: 12 additions & 0 deletions lib/rules/__tests__/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';

const rules = require('..');

describe('rules', () => {
for (const [ruleName, rule] of Object.entries(rules)) {
test(`the "${ruleName}" rule has metadata`, () => {
expect(rule.meta).toBeTruthy();
expect(rule.meta.url).toMatch(/^https:\/\/stylelint\.io\/.+/);
});
}
});
5 changes: 5 additions & 0 deletions lib/rules/alpha-value-notation/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ const messages = ruleMessages(ruleName, {
expected: (unfixed, fixed) => `Expected "${unfixed}" to be "${fixed}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/alpha-value-notation',
};

const ALPHA_PROPS = new Set(['opacity', 'shape-image-threshold']);
const ALPHA_FUNCS = new Set(['hsl', 'hsla', 'hwb', 'lab', 'lch', 'rgb', 'rgba']);

Expand Down Expand Up @@ -193,4 +197,5 @@ function isNumber(value) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-allowed-list/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ const messages = ruleMessages(ruleName, {
rejected: (name) => `Unexpected at-rule "${name}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-allowed-list',
};

/** @type {import('stylelint').Rule} */
const rule = (primary) => {
// To allow for just a string as a parameter (not only arrays of strings)
Expand Down Expand Up @@ -56,4 +60,5 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-disallowed-list/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ const messages = ruleMessages(ruleName, {
rejected: (name) => `Unexpected at-rule "${name}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-disallowed-list',
};

/** @type {import('stylelint').Rule} */
const rule = (primary) => {
// To allow for just a string as a parameter (not only arrays of strings)
Expand Down Expand Up @@ -56,4 +60,5 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-empty-line-before/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ const messages = ruleMessages(ruleName, {
rejected: 'Unexpected empty line before at-rule',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-empty-line-before',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, secondaryOptions, context) => {
return (root, result) => {
Expand Down Expand Up @@ -164,4 +168,5 @@ function isAtRuleAfterSameNameAtRule(atRule) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-name-case/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ const messages = ruleMessages(ruleName, {
expected: (actual, expected) => `Expected "${actual}" to be "${expected}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-name-case',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, _secondary, context) => {
return (root, result) => {
Expand Down Expand Up @@ -57,4 +61,5 @@ const rule = (primary, _secondary, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-name-newline-after/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ const messages = ruleMessages(ruleName, {
expectedAfter: (name) => `Expected newline after at-rule name "${name}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-name-newline-after',
};

/** @type {import('stylelint').Rule} */
const rule = (primary) => {
const checker = whitespaceChecker('newline', primary, messages);
Expand All @@ -36,4 +40,5 @@ const rule = (primary) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-name-space-after/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ const messages = ruleMessages(ruleName, {
expectedAfter: (name) => `Expected single space after at-rule name "${name}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-name-space-after',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, _secondary, context) => {
const checker = whitespaceChecker('space', primary, messages);
Expand Down Expand Up @@ -43,4 +47,5 @@ const rule = (primary, _secondary, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-no-unknown/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ const messages = ruleMessages(ruleName, {
rejected: (atRule) => `Unexpected unknown at-rule "${atRule}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-no-unknown',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, secondaryOptions) => {
return (root, result) => {
Expand Down Expand Up @@ -63,4 +67,5 @@ const rule = (primary, secondaryOptions) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-no-vendor-prefix/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ const messages = ruleMessages(ruleName, {
rejected: (p) => `Unexpected vendor-prefixed at-rule "@${p}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-no-vendor-prefix',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, _secondary, context) => {
return (root, result) => {
Expand Down Expand Up @@ -54,4 +58,5 @@ const rule = (primary, _secondary, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
6 changes: 5 additions & 1 deletion lib/rules/at-rule-property-required-list/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ const messages = ruleMessages(ruleName, {
expected: (property, atRule) => `Expected property "${property}" for at-rule "${atRule}"`,
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-property-required-list',
};

/** @type {import('stylelint').Rule} */
const rule = (primary) => {
return (root, result) => {
Expand Down Expand Up @@ -64,5 +68,5 @@ const rule = (primary) => {

rule.ruleName = ruleName;
rule.messages = messages;

rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-semicolon-newline-after/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ const messages = ruleMessages(ruleName, {
expectedAfter: () => 'Expected newline after ";"',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-semicolon-newline-after',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, _secondary, context) => {
const checker = whitespaceChecker('newline', primary, messages);
Expand Down Expand Up @@ -74,4 +78,5 @@ const rule = (primary, _secondary, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/at-rule-semicolon-space-before/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ const messages = ruleMessages(ruleName, {
rejectedBefore: () => 'Unexpected whitespace before ";"',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/at-rule-semicolon-space-before',
};

/** @type {import('stylelint').Rule} */
const rule = (primary) => {
const checker = whitespaceChecker('space', primary, messages);
Expand Down Expand Up @@ -59,4 +63,5 @@ const rule = (primary) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/block-closing-brace-empty-line-before/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const messages = ruleMessages(ruleName, {
rejected: 'Unexpected empty line before closing brace',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/block-closing-brace-empty-line-before',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, secondaryOptions, context) => {
return (root, result) => {
Expand Down Expand Up @@ -119,4 +123,5 @@ const rule = (primary, secondaryOptions, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/block-closing-brace-newline-after/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ const messages = ruleMessages(ruleName, {
rejectedAfterMultiLine: () => 'Unexpected whitespace after "}" of a multi-line block',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/block-closing-brace-newline-after',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, secondaryOptions, context) => {
const checker = whitespaceChecker('newline', primary, messages);
Expand Down Expand Up @@ -142,4 +146,5 @@ const rule = (primary, secondaryOptions, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/block-closing-brace-newline-before/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ const messages = ruleMessages(ruleName, {
rejectedBeforeMultiLine: 'Unexpected whitespace before "}" of a multi-line block',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/block-closing-brace-newline-before',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, _secondaryOptions, context) => {
return (root, result) => {
Expand Down Expand Up @@ -122,4 +126,5 @@ const rule = (primary, _secondaryOptions, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/block-closing-brace-space-after/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const messages = ruleMessages(ruleName, {
rejectedAfterMultiLine: () => 'Unexpected whitespace after "}" of a multi-line block',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/block-closing-brace-space-after',
};

/** @type {import('stylelint').Rule} */
const rule = (primary) => {
const checker = whitespaceChecker('space', primary, messages);
Expand Down Expand Up @@ -87,4 +91,5 @@ const rule = (primary) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/block-closing-brace-space-before/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const messages = ruleMessages(ruleName, {
rejectedBeforeMultiLine: () => 'Unexpected whitespace before "}" of a multi-line block',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/block-closing-brace-space-before',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, _secondaryOptions, context) => {
const checker = whitespaceChecker('space', primary, messages);
Expand Down Expand Up @@ -99,4 +103,5 @@ const rule = (primary, _secondaryOptions, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/block-no-empty/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ const messages = ruleMessages(ruleName, {
rejected: 'Unexpected empty block',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/block-no-empty',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, secondaryOptions) => {
return (root, result) => {
Expand Down Expand Up @@ -82,4 +86,5 @@ const rule = (primary, secondaryOptions) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;
5 changes: 5 additions & 0 deletions lib/rules/block-opening-brace-newline-after/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const messages = ruleMessages(ruleName, {
rejectedAfterMultiLine: () => 'Unexpected whitespace after "{" of a multi-line block',
});

const meta = {
url: 'https://stylelint.io/user-guide/rules/list/block-opening-brace-newline-after',
};

/** @type {import('stylelint').Rule} */
const rule = (primary, secondaryOptions, context) => {
const checker = whitespaceChecker('newline', primary, messages);
Expand Down Expand Up @@ -172,4 +176,5 @@ const rule = (primary, secondaryOptions, context) => {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = meta;
module.exports = rule;