Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive for ::-moz-focus-inner in no-descending-specificity #5831

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Fix false positive for ::-moz-focus-inner in no-descending-specificity #5831

merged 2 commits into from
Jan 14, 2022

Conversation

Crocsx
Copy link
Contributor

@Crocsx Crocsx commented Jan 14, 2022 •
edited 

Which issue, if any, is this issue related to?

Closes #5032

This looks like a simple fix ?
I tried to run all the test and it looks OK.

Do you see any issue that could come from this ?

jeddy3
jeddy3 approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crocsx Thanks for the pull request.

LGTM.

ybiquitous
ybiquitous approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crocsx Thanks. LGTM!

lib/reference/keywordSets.js Outdated Show resolved Hide resolved
ybiquitous
ybiquitous approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crocsx Thank you! 😄

@ybiquitous ybiquitous merged commit 1322dd2 into stylelint:main Jan 14, 2022
@ybiquitous
Copy link
Member

  • Fixed: no-descending-specificity false positives for the ::-moz-focus-inner pseudo-element (#5831).

CHANGELOG updated. 674ed5e

@ybiquitous
Copy link
Member

Oops. HEAD missing. 😓

@ybiquitous
Copy link
Member

Head section added. 076ef6d

@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positive for ::-moz-focus-inner in no-descending-specificity
3 participants
@Crocsx @ybiquitous @jeddy3