Add autofix to font-family-name-quotes

[MrBrN197]

Which issue, if any, is this issue related to?

Closes #5805

Is there anything in the PR that needs further explanation?

• On this line I am using the result object to check against the string-quotes rule to determine whether to replace with single or double-quotes. I'm not sure whether this is wise or not. I'm not sure what order the rules run in so if the font-family-name-quotes rule runs after the string-quotes this might cause it to replace with the wrong type of quotes and string-quotes will not get a chance to fix this.
• checkFamilyName returns an object when context.fix is enabled and complain doesn't run. modifying the decl.value inside checkFamilyName would result in the other fontFamilyNode.sourceIndexs' being wrong so I defer this until after the loop. I'm not sure if this is the best way to go about this. but to avoid rewriting a lot of the code this is what I decided to do. some clarification on this would be nice.

[ybiquitous]

@MrBrN197 Thank you for creating the pull request and sorry for the late response.

• On this line I am using the result object to check against the string-quotes rule to determine whether to replace with single or double-quotes. I'm not sure whether this is wise or not. I'm not sure what order the rules run in so if the font-family-name-quotes rule runs after the string-quotes this might cause it to replace with the wrong type of quotes and string-quotes will not get a chance to fix this.

With the current implementation, string-quotes is executed after font-family-name-quotes, that is, by the order defined lib/rules/index.js. See below:

stylelint/lib/lintPostcssResult.js

Lines 57 to 61 in 8a4253a

	const rules = config.rules
	? Object.keys(config.rules).sort(
	(a, b) => Object.keys(rulesOrder).indexOf(a) - Object.keys(rulesOrder).indexOf(b),
	)
	: [];

stylelint/lib/rules/index.js

Line 8 in 8a4253a

const rules = {

This behavior is undocumented as far as I know and may be changed in the future. However, since it will be as-is for a while, I recommend removing the code referring config.rules['string-quotes'].

So, it doesn't seem to be a big problem, even if font-family-name-quotes always fixes CSS with single quotes (or double quotes).

• checkFamilyName returns an object when context.fix is enabled and complain doesn't run. modifying the decl.value inside checkFamilyName would result in the other fontFamilyNode.sourceIndexs' being wrong so I defer this until after the loop. I'm not sure if this is the best way to go about this. but to avoid rewriting a lot of the code this is what I decided to do. some clarification on this would be nice.

OK, I'll review the code more.

[ybiquitous]

[suggest] Can you please add the following description to the font-family-name-quotes doc?

stylelint/lib/rules/string-quotes/README.md

Line 28 in 8a4253a

The [`fix` option](../../../docs/user-guide/usage/options.md#fix) can automatically fix most of the problems reported by this rule.

[ybiquitous]

[suggest] Can you move fixed: next to code: like other cases?

[ybiquitous]

@MrBrN197 I've left some suggestions. I would appreciate them if you could consider them. 😃

[jeddy3]

@MrBrN197 Thanks for the pull request.

So, it doesn't seem to be a big problem, even if font-family-name-quotes always fixes CSS with single quotes (or double quotes).

Yes, let's always fix with double quotes. It's what the standard config uses because double quotes are most commonly used in the specification examples.

[jeddy3]

@MrBrN197 Thanks for making those changes.

Can you also implement @ybiquitous' two suggestions above, and then I think we'll be ready for a final review?

[MrBrN197]

@jeddy3 Hey, Thanks, Yes I'm getting on the other changes.

[ybiquitous]

@MrBrN197 Thank you and sorry for the late response. Great work. 👍🏼

I've left some easy refactoring suggestions, so please consider them.

[MrBrN197]

@ybiquitous Thanks for the feedback. I've made those changes.

[ybiquitous]

@MrBrN197 Great! LGTM 👍🏼

[ota-meshi]

I think we need to mark the rule as (Autofixable) in the list of rules.
https://github.com/stylelint/stylelint/blob/main/docs/user-guide/rules/list.md

[jeddy3]

@MrBrN197 Thank you! LGTM.

[jeddy3]

Changelog entry:

• Added: font-family-name-quotes autofix (#5806).