Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document requiring custom syntaxes in shared configs #5728

Merged
merged 2 commits into from Nov 22, 2021
Merged

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Nov 21, 2021

Which issue, if any, is this issue related to?

Closes #5632

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@jeddy3
Copy link
Member Author

jeddy3 commented Nov 21, 2021

Do we need coveralls, or can someone with access remove it?

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 Thanks! LGTM! 👍🏼

docs/developer-guide/syntaxes.md Outdated Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3 jeddy3 merged commit 4aca7ae into main Nov 22, 2021
@jeddy3 jeddy3 deleted the issue-5632 branch November 22, 2021 09:57
@ybiquitous ybiquitous mentioned this pull request Nov 26, 2021
@clown-helang
Copy link

Has the new version of this issue been released?

@jeddy3
Copy link
Member Author

jeddy3 commented Mar 28, 2022

@clown-helang This was a documentation change that's live on the website and shared configs are now following the recommendation, e.g. the SCSS one uses:

customSyntax: require('postcss-scss'),

The customSyntax configuration property has been available since 14.0.0, which was released a few months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix custom syntax module path not properly resolving
3 participants