Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use PostCSS Container type for more flexibility #5708

Merged
merged 1 commit into from Nov 9, 2021

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Nov 9, 2021

Which issue, if any, is this issue related to?

Fixes the type error on #5689

Is there anything in the PR that needs further explanation?

Instead of import('postcss').Rule | import('postcss').AtRule, this refactoring uses the import('postcss').Container type.
This type includes also import('postcss').Root so has more flexibility.

See the type definitions of PostCSS below:

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner and more flexible, thanks!

@jeddy3 jeddy3 merged commit b91bc26 into main Nov 9, 2021
@jeddy3 jeddy3 deleted the refactor-to-use-postcss-container-type branch November 9, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants