Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extending rules within overrides #5683

Merged
merged 2 commits into from Nov 8, 2021
Merged

Fix extending rules within overrides #5683

merged 2 commits into from Nov 8, 2021

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

Closes #5656

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@jeddy3
Copy link
Member

jeddy3 commented Nov 1, 2021

@ota-meshi Thanks for working on this. The behaviour in the tests LGTM.

@ota-meshi ota-meshi marked this pull request as ready for review November 1, 2021 09:35
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ota-meshi Thanks, looks good! 👍🏼

@jeddy3 jeddy3 merged commit 7829275 into main Nov 8, 2021
@jeddy3 jeddy3 deleted the override-priority branch November 8, 2021 17:35
@jeddy3
Copy link
Member

jeddy3 commented Nov 8, 2021

  • Fixed: extending rules within overrides (#5683).

(I've not had time for Stylelint recently, but going to dip into a few pull requests now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix extending rules within overrides
3 participants