Add support for directory creation to --output-file flag #5672
Conversation
There was a problem hiding this comment.
@dreyks Thanks for creating this patch quickly! Can you add a test case?
|
For example, it seems good to add simple test cases: // lib/__tests__/writeOutputFile.test.js
'use strict';
const writeOutputFile = require('../writeOutputFile');
describe('writeOutputFile', () => {
it('creates a file', () => {
// ...
});
it('creates a directory if it does not exist', () => {
// ...
});
}); |
|
should this test write to the real FS or do we want to add memfs or similar? |
|
Can you use the real FS? |
|
i can. i'll just clean up tmp files after each test |
lib/__tests__/outputFile.test.js
Outdated
|
|
||
| expect((await fs.readFile(filePath)).toString()).toEqual('test content'); | ||
|
|
||
| await fs.rmdir(path.dirname(filePath), { recursive: true }); |
There was a problem hiding this comment.
this looks a bit concerning, maybe I should replace this with
await fs.unlink(filePath)
await fs.rmDir(path.dirname(filePath))so that there's no way to accidentally remove more than we expect :)
|
i think i still need a second approval to merge this. do I need to do anything else or is the process now on your (stylelint maintainers) side? |
jeddy3
changed the title
There was a problem hiding this comment.
@dreyks Thanks for the pull request. LGTM.
were removed in a big refactoring PR
Oops, removing them was probably a mistake by me...
do I need to do anything else or is the process now on your (stylelint maintainers) side?
It's on our side.
|
Changelog entry added:
|
Closes #5670
Looks like the test-files that were a part of the original PR were removed in a big refactoring PR so I haven't added any