Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for hyphenated functions in function-calc-no-unspaced-operator #5636

Merged
merged 11 commits into from Oct 25, 2021
Merged

Fix false positives for hyphenated functions in function-calc-no-unspaced-operator #5636

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5ec208f
remove style-search to fix #5517
lachieh Oct 19, 2021
3ee06a9
attempt to fix security issue with replace method
lachieh Oct 19, 2021
0146cf2
remove additional `.replace` method
lachieh Oct 19, 2021
7820c98
Merge branch 'master' into bugfix-5517
lachieh Oct 21, 2021
89ef9e0
remove invalid less variable test and related code
lachieh Oct 22, 2021
c05dfb8
Update lib/rules/function-calc-no-unspaced-operator/index.js
lachieh Oct 24, 2021
a7c2b05
implement changes from review
lachieh Oct 24, 2021
60adbfb
inline functions and implement suggestions
lachieh Oct 25, 2021
13740e6
inline one more function
lachieh Oct 25, 2021
0ed074f
Update return value of `isSingleSpace` function
lachieh Oct 25, 2021
a5f1208
update variable naming
lachieh Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/rules/function-calc-no-unspaced-operator/__tests__/index.js
View file
Open in desktop
Expand Up @@ -87,6 +87,10 @@ testRule({
code: 'a { top: calc(\t+1px)}',
description: 'tab before sign at start',
},
{
code: 'a { top: calc(100% - --my-custom-function(1rem)); }',
description: 'custom function with hyphens in name',
},
{
code: 'a { top: calc(-$x - 2rem); }',
description: 'postcss-simple-vars and SCSS variable syntax',
Expand All @@ -100,7 +104,7 @@ testRule({
description: 'postcss-simple-vars and SCSS variable with hyphens',
},
{
code: 'a { top: calc(2rem + @fh+d*sf-as); }',
code: 'a { top: calc(2rem + @fh+dsf-as); }',
description: 'Less variable with symbols',
},
{
Expand Down Expand Up @@ -154,6 +158,15 @@ testRule({
],

reject: [
{
code: 'a { top: calc(2px+1px) }',
fixed: 'a { top: calc(2px + 1px) }',
description: 'no space before or after operator',
warnings: [
{ message: messages.expectedBefore('+'), line: 1, column: 18 },
{ message: messages.expectedAfter('+'), line: 1, column: 19 },
],
},
{
code: 'a { top: calc(1px +\t-1px)}',
fixed: 'a { top: calc(1px + -1px)}',
Expand Down