Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overrides property ignoring dot directories #5629

Merged
merged 1 commit into from Oct 22, 2021
Merged

Fix overrides property ignoring dot directories #5629

merged 1 commit into from Oct 22, 2021

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

Closes #5628

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'm away and heading offline for a couple of days now if someone wants to release a patch for this while I'm away; otherwise, I can release when I'm back.

ybiquitous
ybiquitous approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@ybiquitous ybiquitous merged commit 397586e into main Oct 22, 2021
@ybiquitous ybiquitous deleted the issue-5628 branch October 22, 2021 14:28
ybiquitous added a commit that referenced this pull request Oct 22, 2021
@ybiquitous
Update CHANGELOG.md for #5629
2bd5ba9
@ybiquitous
Copy link
Member

Updated Changelog:

  • Fixed: overrides property ignoring dot directories (#5629).

@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix overrides property ignoring dot directories
3 participants
@ota-meshi @ybiquitous @jeddy3