New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show more info in missing customSyntax warning #5611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message is much better, thanks!
I've requested one small change.
lib/getPostcssResult.js
Outdated
js: '@stylelint/postcss-css-in-js', | ||
jsx: '@stylelint/postcss-css-in-js', | ||
less: 'postcss-less', | ||
md: '@stylelint/postcss-markdown', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
md: '@stylelint/postcss-markdown', | |
md: 'postcss-markdown', |
We're going to deprecate our fork in favour of the original package. It works fine. It just needs someone to take ownership and update the dependencies at some point.
@stylelint/postcss-css-in-js
is the special case as quite a bit of work was done to it since it was forked from the original package, so our fork will need to stick around a while until we can deprecate it (see https://github.com/stylelint/postcss-css-in-js/issues/225)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
#5604 (comment)
Now message included file path to understand what file causes the warning. And suggest known syntax to previously inferred extensions.
Before:
After: