Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using shared configs #5598

Merged
merged 9 commits into from Oct 18, 2021
Merged

Recommend using shared configs #5598

merged 9 commits into from Oct 18, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Oct 17, 2021

Which issue, if any, is this issue related to?

Follows on from: #5563
Ref: #5205

Is there anything in the PR that needs further explanation?

It's likely the SCSS configs and plugins will be ready for release, see:

This pull request updates the 14.0.0 migration guide and getting started page to recommend installing a shared config for your preferred language.

It's a dramatic shift from syntax inferral to explicit configuration, and we should emphasise shared configs as the best way to do that configuration. They are the easiest way for users to get up and running with comprehensive linting that doesn't leave gaps.


If you use Stylelint to lint SCSS, please have a look at the above pull request especially what rules the configs turn on.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change looks good and should be useful for SCSS and SugarSS users! 😄

I've left trivial suggestions to improve the surface of documents, but I agree with the main policy of the change. 👍🏼

docs/migration-guide/to-14.md Outdated Show resolved Hide resolved
docs/migration-guide/to-14.md Outdated Show resolved Hide resolved
docs/migration-guide/to-14.md Outdated Show resolved Hide resolved
docs/migration-guide/to-14.md Outdated Show resolved Hide resolved
docs/user-guide/get-started.md Outdated Show resolved Hide resolved
docs/user-guide/get-started.md Outdated Show resolved Hide resolved
@jeddy3
Copy link
Member Author

jeddy3 commented Oct 18, 2021

@ybiquitous Thanks for all the catches! I've committed them all.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 Thanks. LGTM! 👍🏼

@jeddy3 jeddy3 mentioned this pull request Oct 18, 2021
30 tasks
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's out of scope of this PR, but maybe we could remove a message in a migration guide that postcss-html needs a maintaner?

Comment on lines 7 to 8
- parse CSS-like syntaxes like SCSS, Less and SugarSS
- extract styles from HTML, JavaScript and Markdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking if this messaging is making sense to the end user. It's a PostCSS syntax, which is parses something, or extract something. Our users don't use Stylelint to parse or extract, they use it for lint. Maybe we can reword selected lines to highlight that Stylelint could be used with different syntaxes, including files, where CSS is embed into different language?

P. S. It's weird to write Stylelint from capital letter after all these years of writing it with lower case :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a commit (5384f54) to make it clear that it's the PostCSS syntaxes doing the parsing/extracting, and that a PostCSS syntax is needed if linting anything other than CSS.

P. S. It's weird to write Stylelint from capital letter after all these years of writing it with lower case :)

Ha, I know! I keep catching myself doing it.

jeddy3 and others added 7 commits October 18, 2021 21:37
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@@ -2,9 +2,9 @@

Stylelint is designed for CSS.

However, it can be extended to:
However, it can used with [PostCSS syntaxes](https://github.com/postcss/postcss#syntaxes) that:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't know if it's a typo I spotted, or it's part of English I don't know :) Is “be” needed after “can”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it is!

@jeddy3 jeddy3 merged commit bf28025 into v14 Oct 18, 2021
@jeddy3 jeddy3 deleted the config-migration branch October 18, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants