Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace violation with problem in docs and types #5592

Merged
merged 1 commit into from Oct 12, 2021
Merged

Replace violation with problem in docs and types #5592

merged 1 commit into from Oct 12, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Oct 11, 2021 •
edited

Which issue, if any, is this issue related to?

Closes #5591

Is there anything in the PR that needs further explanation?

It was a quick find-and-replace job. We're dotting the i's and crossing the t's now for the release.

Related website commit: stylelint/stylelint.io@0af080f

FYI @adalinesimonian, this touches on your types added in #5582.

@jeddy3 jeddy3 mentioned this pull request Oct 11, 2021
Closed
adalinesimonian
adalinesimonian approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@adalinesimonian adalinesimonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to types and such LGTM. I'll update the Stylelint dependency downstream in the extension once again when this is merged and see if there is any related lingo I need to update.

@jeddy3 jeddy3 changed the title Replace problem with violation in docs and types Replace violation with problem in docs and types Oct 11, 2021
ybiquitous
ybiquitous approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@jeddy3 jeddy3 merged commit e38da70 into v14 Oct 12, 2021
@jeddy3 jeddy3 deleted the issue-5591 branch October 12, 2021 07:11
@chalkygames123 chalkygames123 mentioned this pull request Dec 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@adalinesimonian adalinesimonian adalinesimonian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeddy3 @ybiquitous @adalinesimonian