Refactor atrule statement in unit-no-unknown #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
reviewed
Sep 5, 2021
There was a problem hiding this comment.
@sylwia-lask Thanks for creating the PR! I've commented on a refactoring suggestion, so can you check it out?
lib/rules/unit-no-unknown/index.js
Outdated
| @@ -129,7 +130,7 @@ function rule(actual, options) { | |||
| } | |||
|
|
|||
| root.walkAtRules((atRule) => { | |||
| if (!/^media$/i.test(atRule.name) && !atRule.variable) { | |||
| if (!/^media$/i.test(atRule.name) && !isStandardSyntaxAtRule(atRule)) { | |||
There was a problem hiding this comment.
[suggestion] Can we move the position of /^media$/i as below? I think it's more readable. 😃
root.walkAtRules(/^media$/i, (atRule) => {
if (!isStandardSyntaxAtRule(atRule)) {
There was a problem hiding this comment.
Yep, we should be using the walk* filter when available. I think most rules do, but it looks like this one must have slipped through at some point.
There was a problem hiding this comment.
@ybiquitous @jeddy3 thanks a lot guys for your review :)
sylwia-lask
force-pushed
the
refactor-atrule-statement-in-unit-no-unknown
branch
from
5d49cdf
to
d93de00
Compare
ybiquitous
approved these changes
Sep 6, 2021
jeddy3
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is related to discussion in #5500 - introduce isStandardAtRule.
No, it's self-explanatory.