Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for prefers-contrast in media-feature-name-no-unknown #5428

Merged
merged 2 commits into from Jul 28, 2021
Merged

Fix false positives for prefers-contrast in media-feature-name-no-unknown #5428

merged 2 commits into from Jul 28, 2021

Conversation

danrichman
Copy link
Contributor

This is a new media query added to CSS Media Queries Level 5 to utilize the contrast preference operating systems provide.

Which issue, if any, is this issue related to?

Closes #5427

Is there anything in the PR that needs further explanation?

Please see issue #5427

@danrichman
Added prefers-contrast media query
02f45bb 
This is a new media query added to CSS Media Queries Level 5 to utilize the contrast preference operating systems provide.

Closes stylelint#5427
@jeddy3 jeddy3 changed the base branch from master to v14 July 27, 2021 18:11
jeddy3
jeddy3 requested changes Jul 27, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, and for using the templates here and in the issue.

I've requested a small change to fix a typo.

lib/reference/keywordSets.js Outdated Show resolved Hide resolved
@danrichman @jeddy3
Update lib/reference/keywordSets.js
196a273 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@danrichman danrichman requested a review from jeddy3 July 27, 2021 19:47
jeddy3
jeddy3 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for committing the suggestion.

LGTM.

This is being merged into v14 that we need help getting out the door. In the meantime, you can use disable comments or the ignoreMediaFeatureNames secondary option.

ybiquitous
ybiquitous approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍🏼

@jeddy3 jeddy3 merged commit 1e83790 into stylelint:v14 Jul 28, 2021
@jeddy3
Copy link
Member

jeddy3 commented Jul 28, 2021

Changelog entry added:

  • Fixed: media-feature-name-no-unknown false positives for prefers-contrast (#5428).

@danrichman danrichman deleted the patch-1 branch July 28, 2021 22:57
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for prefers-contrast in media-feature-name-no-unknown
3 participants
@danrichman @jeddy3 @ybiquitous