Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignoreProperties: [] to number-max-precision #5421

Merged
merged 5 commits into from Aug 10, 2021
Merged

Add ignoreProperties: [] to number-max-precision #5421

merged 5 commits into from Aug 10, 2021

Conversation

eljusto
Copy link
Contributor

@eljusto eljusto commented Jul 22, 2021

Which issue, if any, is this issue related to?

Resolved #5420

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@jeddy3 jeddy3 changed the title Added ignoreProperties option to number-max-precision rule Add ignoreProperties: [] to number-max-precision Jul 26, 2021
jeddy3
jeddy3 requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eljusto Thank you for the pull request. Adding this option SGTM.

Can you please:

  1. set the pull request to merge into the v14 branch
  2. add the option to the rule README (like so)

@eljusto eljusto changed the base branch from master to v14 August 3, 2021 14:46
@eljusto eljusto requested a review from jeddy3 August 3, 2021 15:15
jeddy3
jeddy3 requested changes Aug 5, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. I've requested two more changes as suggestions.

lib/rules/number-max-precision/README.md Show resolved Hide resolved
lib/rules/number-max-precision/README.md Outdated Show resolved Hide resolved
@eljusto @jeddy3
Apply suggestions from code review
5ebc78a 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
ybiquitous
ybiquitous approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

lib/rules/number-max-precision/README.md Outdated Show resolved Hide resolved
@eljusto @ybiquitous
Update lib/rules/number-max-precision/README.md
8884e56 
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
jeddy3
jeddy3 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeddy3 jeddy3 merged commit 421b073 into stylelint:v14 Aug 10, 2021
@jeddy3
Copy link
Member

jeddy3 commented Aug 10, 2021

v14 changelog entry:

  • Added: ignoreProperties: [] to number-max-precision (#5421).

@eljusto eljusto deleted the number-max-precision-ignore-props branch August 11, 2021 09:15
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@ybiquitous ybiquitous mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignoreProperties: [] to number-max-precision
3 participants
@eljusto @jeddy3 @ybiquitous