Refactor lib/__tests__/needlessDisables.test.js
#5287
Conversation
- Reduce callbacks as much as possible via `async/await` syntax. (see also <https://jestjs.io/docs/asynchronous>) - Replace the use of `stripIndent()` with `trim()`. (avoiding indentation in template string literals)
There was a problem hiding this comment.
Replace the use of stripIndent() with trim(). (avoiding indentation in template string literals)
We use stripIndent because it, arguably, makes the source files easier to read/scan as the indentation is consistent across the file. I'm in a favour of keeping it and fixing the alignment so that the template literals are aligned with their surrounding JavaScript code. Or are there reasons to remove it? We'll want to apply which ever approach consistently across the codebase.
|
@jeddy3 Thanks for the feedback! I have no strong opinion and want to keep consistency, so I'll follow our community decision. Unfortunately, auto-formatting by Prettier is not available, but I’ll re-indent template string literals with TABs. |
| }, | ||
| { | ||
| line: 11, | ||
| column: 21, |
There was a problem hiding this comment.
[note] This column change from 22 to 21 is caused by re-indentation with TABs.
async/awaitsyntax. (see also https://jestjs.io/docs/asynchronous)Replace the use ofstripIndent()withtrim(). (avoiding indentation in template string literals)A part of #4881
It's easier to review the diffs if using "Hide whitespace changes".