Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/utils/__tests__/nodeContextLookup.test.js #5238

Merged
merged 1 commit into from Apr 11, 2021
Merged

Refactor lib/utils/__tests__/nodeContextLookup.test.js #5238

merged 1 commit into from Apr 11, 2021

Conversation

ybiquitous
Copy link
Member

This refactoring aims to avoid asynchronous callbacks in the test code.

Which issue, if any, is this issue related to?

Part of #4881

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@ybiquitous
Refactor lib/utils/__tests__/nodeContextLookup.test.js
157e2ec 
This refactoring aims to avoid asynchronous callbacks in the test code.
@ybiquitous ybiquitous mentioned this pull request Apr 9, 2021
Closed
@ybiquitous ybiquitous marked this pull request as ready for review April 9, 2021 18:19
mattxwang
mattxwang approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the continued refactoring!

@jeddy3 jeddy3 merged commit 0500d7e into master Apr 11, 2021
@jeddy3 jeddy3 deleted the refactor-nodeContextLookup.test.js branch April 11, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ybiquitous @mattxwang @jeddy3