Fix false positives for level 4 math functions in length-zero-no-unit #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomyo
force-pushed
the
ignore-level-4-math-functions-in-length-zero-no-unit
branch
from
a143e5e
to
01a4e81
Compare
ybiquitous
approved these changes
Mar 23, 2021
|
Changelog entry added:
|
lucaswerkmeister
added a commit
to wmde/wikit
that referenced
this pull request
Jun 15, 2021
This includes a fix for false positives of the length-zero-no-unit rule in min() or max() (see stylelint/stylelint#5203 [1]). [1]: stylelint/stylelint#5203
lucaswerkmeister
added a commit
to wmde/wikit
that referenced
this pull request
Jun 17, 2021
This includes a fix for false positives of the length-zero-no-unit rule in min() or max() (see stylelint/stylelint#5203 [1]). [1]: stylelint/stylelint#5203
sai-san
added a commit
to wmde/wikit
that referenced
this pull request
Jun 21, 2021
* Update stylelint to 13.13.1 This includes a fix for false positives of the length-zero-no-unit rule in min() or max() (see stylelint/stylelint#5203 [1]). [1]: stylelint/stylelint#5203 * Check for overflow in Popover We try to avoid overflow with several adjustments – see the comments of the avoidOverflow…() methods for details. Adjustments that change the `position` prop can be disabled with the new `forcePosition` prop. Each adjustment is tried in order, only if the previous adjustments weren’t enough to avoid the overflow, and the adjustments are cumulative. The whole procedure to avoid overflow is repeated each time the popover is shown, as well as on window resize and when the position prop changes. However, we don’t listen to changes in the slot contents, because there seems to be no straightforward way to do that, and implementing it probably wouldn’t be worth the effort (it would mainly be useful for the storybook, I assume). The “making edges flush” adjustment uses the CSS min() function, which is not available in IE11; however, that should only mean that the adjustment is effectively disabled in IE11 (the value should fall back to the non-flush rule, some calc(...)), without breaking anything else. Bug: T274261 Co-authored-by: SaiSan <sarai.sanchez@wikimedia.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5199
First commit is simply small styling alignment, not part of the issue, but small enough to simply include here I guess.