Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add named-grid-areas-no-invalid #5167

Merged
merged 46 commits into from Mar 5, 2021
Merged

Add named-grid-areas-no-invalid #5167

merged 46 commits into from Mar 5, 2021

Commits on Feb 21, 2021

  1. adds README.md

    @evrom
    evrom committed Feb 21, 2021
    Copy the full SHA
    f189843 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. adds rules for grid-template-areas

    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    ceeb4a1 View commit details
    Browse the repository at this point in the history

  2. remove comment from value before parsing grid

    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    13fd708 View commit details
    Browse the repository at this point in the history

  3. Do not use matchAll 

    Node version 10, supported by the test matrix, does not support
.matchAll
    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    b930a18 View commit details
    Browse the repository at this point in the history

  4. use _.flatten instead of Array.prototype.flat 

    because node version 10 does not support `Array.prototype.flat`
    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    75cad76 View commit details
    Browse the repository at this point in the history

  5. Update lib/rules/named-grid-areas-no-invalid/README.md 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 23, 2021
    Copy the full SHA
    60aac69 View commit details
    Browse the repository at this point in the history

  6. Update lib/rules/named-grid-areas-no-invalid/README.md 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 23, 2021
    Copy the full SHA
    90173e3 View commit details
    Browse the repository at this point in the history

  7. Update lib/rules/named-grid-areas-no-invalid/README.md 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 23, 2021
    Copy the full SHA
    3e76615 View commit details
    Browse the repository at this point in the history

  8. Update lib/rules/named-grid-areas-no-invalid/README.md 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 23, 2021
    Copy the full SHA
    061fb27 View commit details
    Browse the repository at this point in the history

  9. Update lib/rules/named-grid-areas-no-invalid/__tests__/index.js 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 23, 2021
    Copy the full SHA
    9a0f36f View commit details
    Browse the repository at this point in the history

  10. use a tag in css examples

    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    3581dca View commit details
    Browse the repository at this point in the history

  11. use valueParser from 'postcss-value-parser'

    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    0312bd8 View commit details
    Browse the repository at this point in the history

  12. move rule function above helper functions 

    as recommended stylelint#5167 (comment)
    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    a973f20 View commit details
    Browse the repository at this point in the history

  13. adds use of validateOptions 

    as recommended stylelint#5167 (comment)
    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    15c743d View commit details
    Browse the repository at this point in the history

  14. use correct columns 

    adds checks for invalid symbols
adds empty row checker
    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    835e732 View commit details
    Browse the repository at this point in the history

  15. make message clearer

    @evrom
    evrom committed Feb 23, 2021
    Copy the full SHA
    8148fde View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. use stripIndent and format testcase 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    5977236 View commit details
    Browse the repository at this point in the history

  2. do not continue testing if errors were reported

    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    c4d30c1 View commit details
    Browse the repository at this point in the history

  3. avoid iterating over nodes multiple times

    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    e2045b0 View commit details
    Browse the repository at this point in the history

  4. add test for multiple non-contiguous areas 

    sort the non-contiguous area names alphabetically to ensure
consistency in error messages
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    9cb4f96 View commit details
    Browse the repository at this point in the history

  5. use a tag in all test cases 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    c1179a4 View commit details
    Browse the repository at this point in the history

  6. use tabs to indent css 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    7b9ad63 View commit details
    Browse the repository at this point in the history

  7. indent css strings one tab 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    75e46d6 View commit details
    Browse the repository at this point in the history

  8. adds test for NONE and none with comments 

    stylelint#5167 (comment)

also changes `column` positions after test case whitespace changes
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    422bad3 View commit details
    Browse the repository at this point in the history

  9. do not use value parser in simple case of none 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    676bd36 View commit details
    Browse the repository at this point in the history

  10. remove testing of invalid symbols 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    79091e9 View commit details
    Browse the repository at this point in the history

  11. use complain() 

    stylelint#5167 (comment)

also fixes this
stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    15edac8 View commit details
    Browse the repository at this point in the history

  12. adds one more test for NONE

    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    fae6be4 View commit details
    Browse the repository at this point in the history

  13. changes warning messages 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    54e718d View commit details
    Browse the repository at this point in the history

  14. do not continue testing grid if non-rectangular 

    It is not worth checking the grid area names for being rectangular
if the grid itself is not rectangular
    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    ff23bb2 View commit details
    Browse the repository at this point in the history

  15. make if statements more readable

    @evrom
    evrom committed Feb 24, 2021
    Copy the full SHA
    60f87ab View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Update lib/rules/named-grid-areas-no-invalid/__tests__/index.js 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 25, 2021
    Copy the full SHA
    8ec63fa View commit details
    Browse the repository at this point in the history

  2. Update lib/rules/named-grid-areas-no-invalid/__tests__/index.js 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 25, 2021
    Copy the full SHA
    e20dba0 View commit details
    Browse the repository at this point in the history

  3. Update lib/rules/named-grid-areas-no-invalid/__tests__/index.js 

    Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
    @evrom @jeddy3
    evrom and jeddy3 committed Feb 25, 2021
    Copy the full SHA
    9167731 View commit details
    Browse the repository at this point in the history

  4. use object destructuring. return instead of... 

    `else`

stylistic changes requested:
stylelint#5167 (comment)
stylelint#5167 (comment)
stylelint#5167 (comment)
    @evrom
    evrom committed Feb 25, 2021
    Copy the full SHA
    5ce08a6 View commit details
    Browse the repository at this point in the history

  5. use destructuring 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 25, 2021
    Copy the full SHA
    79be6b6 View commit details
    Browse the repository at this point in the history

  6. do not define const parsedValue 

    it is only used once, and it doesn't add readability or testability.
    @evrom
    evrom committed Feb 25, 2021
    Copy the full SHA
    5fe13b4 View commit details
    Browse the repository at this point in the history

  7. check properties by case insensitive name

    @evrom
    evrom committed Feb 25, 2021
    Copy the full SHA
    35c67b8 View commit details
    Browse the repository at this point in the history

  8. move complain() to bottom of scope 

    stylelint#5167 (comment)
    @evrom
    evrom committed Feb 25, 2021
    Copy the full SHA
    e6e6992 View commit details
    Browse the repository at this point in the history

  9. adds named-grid-areas-no-invalid rule to list... 

    in docs
    @evrom
    evrom committed Feb 25, 2021
    Copy the full SHA
    f8fd4c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. move utility functions out of index.js

    @evrom
    evrom committed Mar 1, 2021
    Copy the full SHA
    475f571 View commit details
    Browse the repository at this point in the history

  2. adds tests to utils 

    - adds jsdoc for type checking requirements
- removes unused exports of helper functions
    @evrom
    evrom committed Mar 1, 2021
    Copy the full SHA
    403cf68 View commit details
    Browse the repository at this point in the history

  3. refractor utils

    @evrom
    evrom committed Mar 1, 2021
    Copy the full SHA
    fd93b97 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Update docs/user-guide/rules/list.md 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @evrom @ybiquitous
    evrom and ybiquitous committed Mar 4, 2021
    Copy the full SHA
    224ffef View commit details
    Browse the repository at this point in the history

  2. Update lib/rules/named-grid-areas-no-invalid/utils/isRectangular.js 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @evrom @ybiquitous
    evrom and ybiquitous committed Mar 4, 2021
    Copy the full SHA
    24ab53b View commit details
    Browse the repository at this point in the history

  3. Update lib/rules/named-grid-areas-no-invalid/README.md 

    Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
    @evrom @ybiquitous
    evrom and ybiquitous committed Mar 4, 2021
    Copy the full SHA
    992a83e View commit details
    Browse the repository at this point in the history