Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4917 Amend always test case #5050

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions lib/rules/at-rule-empty-line-before/__tests__/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,26 @@ testRule({
],
});

testRule({
ruleName,
config: ['always', { ignore: ['after-comment'] }],
syntax: 'scss',
fix: true,

accept: [
{
code: '// foo\n// bar\n@media {}',
},
{
code: '// foo\n// bar\n\n@media{}',
},
{
code: '// foo\r\n// bar\r\n\r\n@media {}',
description: 'CRLF',
},
],
});

Comment on lines +300 to +319
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 I’ve separated out the test cases as you suggested, but it still passes. Any ideas?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I’m closing this PR, as the issue seems to have been resolved.

testRule({
ruleName,
config: ['always', { ignore: ['first-nested'] }],
Expand Down