Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a specific meta to the deprecated rules #4943

Merged
merged 1 commit into from Sep 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/rules/at-rule-blacklist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/at-rule-blacklist/index.js
Expand Up @@ -59,4 +59,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/at-rule-property-requirelist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,
config: {
Expand Down
1 change: 1 addition & 0 deletions lib/rules/at-rule-property-requirelist/index.js
Expand Up @@ -69,5 +69,6 @@ function rule(list) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/at-rule-whitelist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/at-rule-whitelist/index.js
Expand Up @@ -59,4 +59,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/comment-word-blacklist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,
config: ['bad-word'],
Expand Down
2 changes: 2 additions & 0 deletions lib/rules/comment-word-blacklist/index.js
Expand Up @@ -61,4 +61,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/declaration-property-unit-blacklist/index.js
Expand Up @@ -81,4 +81,6 @@ function rule(list) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/declaration-property-unit-whitelist/index.js
Expand Up @@ -81,4 +81,6 @@ function rule(list) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/declaration-property-value-blacklist/index.js
Expand Up @@ -63,4 +63,6 @@ function rule(list) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/declaration-property-value-whitelist/index.js
Expand Up @@ -63,4 +63,6 @@ function rule(list) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/function-blacklist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/function-blacklist/index.js
Expand Up @@ -66,4 +66,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/function-url-scheme-blacklist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,
config: [[]],
Expand Down
2 changes: 2 additions & 0 deletions lib/rules/function-url-scheme-blacklist/index.js
Expand Up @@ -71,4 +71,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/function-url-scheme-whitelist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,
config: ['https', 'data'],
Expand Down
2 changes: 2 additions & 0 deletions lib/rules/function-url-scheme-whitelist/index.js
Expand Up @@ -71,4 +71,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/function-whitelist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,

Expand Down
2 changes: 2 additions & 0 deletions lib/rules/function-whitelist/index.js
Expand Up @@ -68,4 +68,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
7 changes: 6 additions & 1 deletion lib/rules/media-feature-name-blacklist/__tests__/index.js
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,
config: ['max-width', '--wide-viewport', 'width', '/^my-/', 'color'],
Expand Down
2 changes: 2 additions & 0 deletions lib/rules/media-feature-name-blacklist/index.js
Expand Up @@ -81,4 +81,6 @@ rule.primaryOptionArray = true;

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;
@@ -1,7 +1,7 @@
'use strict';

const standalone = require('../../../standalone');
const { messages, ruleName } = require('..');
const { messages, ruleName, meta } = require('..');

it('warns that the rule is deprecated', () => {
const config = {
Expand All @@ -25,6 +25,11 @@ it('warns that the rule is deprecated', () => {
});
});

it('also warns that the rule is deprecated via a meta', () => {
expect(meta).not.toBeUndefined();
expect(meta).toHaveProperty('deprecated', true);
});

testRule({
ruleName,
config: [
Expand Down
2 changes: 2 additions & 0 deletions lib/rules/media-feature-name-value-whitelist/index.js
Expand Up @@ -94,4 +94,6 @@ function rule(list) {

rule.ruleName = ruleName;
rule.messages = messages;
rule.meta = { deprecated: true };

module.exports = rule;