Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no files matching the pattern error square brackets and dash #4863

Closed
wants to merge 1 commit into from

Conversation

reumia
Copy link

@reumia reumia commented Jul 13, 2020

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

The related issue has already been opened on repository of globby, but it's been passed few years since the issue was opened. So everybody is solving themselves as I do with this PR.

It would be better if I could change globby to some other packages like fast-glob or node-glub but I couldn't because I worried that i can't handle whole side-effects of that change.

I just focused the issue that i've met.
Any suggestions will be appreciated.

@m-allanson
Copy link
Member

Thanks for opening this @reumia. Unfortunately this change will break stylelint for people that want to use [ or ] as part of a glob pattern.

It's a tricky problem, and I don't think it's possible to automatically fix this for every usecase. Therefore I'm going to close this PR for now.

I've written up some workarounds that may help for your case. Thanks again for reporting the issue and opening a PR 👍

@m-allanson m-allanson closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants