Replace 3rd-party type definitions #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces 3rd-party type definitions under the `types/` directory with the following `@types/*` npm packages. - [@types/balanced-match](https://www.npmjs.com/package/@types/balanced-match) - [@types/imurmurhash](https://www.npmjs.com/package/@types/imurmurhash) - [@types/postcss-safe-parser](https://www.npmjs.com/package/@types/postcss-safe-parser) - [@types/style-search](https://www.npmjs.com/package/@types/style-search) - [@types/svg-tags](https://www.npmjs.com/package/@types/svg-tags) - [@types/write-file-atomic](https://www.npmjs.com/package/@types/write-file-atomic) Note that this change does **not** replace all type definitions under `types/`. We should address the remaining types via other pull requests. Related to #4399
ybiquitous
commented
Jul 8, 2020
| throw new Error(`No parens match: "${source}"`); | ||
| } | ||
|
|
||
| const closingParenIndex = parensMatch.end + openingParenIndex; |
There was a problem hiding this comment.
[note] Unless checking !parensMatch, the following type error occurs:
lib/utils/blurFunctionArguments.js:42:41 - error TS2339: Property 'end' does not exist on type 'void | Output'.
Property 'end' does not exist on type 'void'.
42 const closingParenIndex = parensMatch.end + openingParenIndex;
~~~
|
@m-allanson Thank you for the review! We can replace it with also |
mattxwang
approved these changes
Jul 11, 2020
m-allanson
added a commit
that referenced
this pull request
Jul 23, 2020
* master: Update CHANGELOG.md Fix false negatives for where, is, nth-child and nth-last-child in selector-max-* (except selector-max-type) (#4842) Bump @types/lodash from 4.14.155 to 4.14.157 (#4869) Remove `postcss-reporter` package (#4858) Bump lodash from 4.17.15 to 4.17.19 (#4864) Replace 3rd-party type definitions (#4857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4399
This change replaces 3rd-party type definitions under the
types/directory with the following@types/*npm packages.Note that this change does not replace all type definitions under
types/.We should address the remaining types via other pull requests.