A small refactor #4837
Merged
A small refactor #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
m-allanson
commented
Jun 21, 2020
| @@ -40,25 +43,7 @@ module.exports = function (stylelint, options = {}) { | |||
| let syntax = null; | |||
|
|
|||
| if (stylelint._options.customSyntax) { | |||
| try { | |||
| // TODO TYPES determine which type has customSyntax | |||
| const customSyntax = /** @type {any} */ require(stylelint._options.customSyntax); | |||
There was a problem hiding this comment.
This is now using the type @typedef {import('postcss').Syntax} Syntax
| @@ -90,6 +90,8 @@ declare module 'stylelint' { | |||
|
|
|||
| export type FormatterIdentifier = 'compact' | 'json' | 'string' | 'unix' | 'verbose' | Formatter; | |||
|
|
|||
| export type CustomSyntax = string; | |||
There was a problem hiding this comment.
This type will be extended later to be string | Syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another refactor. This moves a couple of chunks of functionality out to separate functions. It's not particularly essential, but (imo) makes it easier to understand what's happening in each file.
This should be the last bit of refactoring from PR #4796. The remaining follow-on PRs should result in new (or changed) functionality instead of rearranging internals.
Related to issue #3935
This change is a small part of the changes in PR #4796