-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new 'lintPostcssResult' module #4819
Conversation
In a future PR this module will be required by the new `browser.js` module. This change has been extracted from: #4796
@@ -84,7 +81,7 @@ module.exports = function lintSource(stylelint, options = {}) { | |||
stylelint: stylelintResult, | |||
}); | |||
|
|||
return lintPostcssResult(stylelint, stylelintPostcssResult, config).then( | |||
return lintPostcssResult(stylelint._options, stylelintPostcssResult, config).then( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stylelint._options
was the only part of the stylelint
object that was being used, so I changed lintPostcssResult()
to accept the options object directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a code motion refactor with only minor changes, looks great to me!
LGTM 👍
# By Mike Allanson (6) and others # Via GitHub * master: Bump got from 11.2.0 to 11.3.0 (#4825) Export an object from the CSS-in-JS syntax (#4824) Add type `Formatter` for formatter functions (#4823) Update CHANGELOG.md Fix false positives for namespaced variables in property-no-unknown (#4803) Update CHANGELOG.md Fix TypeError for inline comments and autofix for sugarss in max-empty-lines (#4821) Create new 'lintPostcssResult' module (#4819) 13.6.0 Update deps Prepare 13.6.0 Update CHANGELOG.md
In a future PR this module will be required by the new
browser.js
module. This change has been extracted from: #4796Related to issue #3935
This change is a small part of the changes in PR #4796