Create new 'createPartialStylelintResult' module #4815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a future PR this module will be required by the new `browser.js` module. This change has been extracted from: #4796
m-allanson
commented
Jun 1, 2020
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| const _ = require('lodash'); | |||
| const createPartialStylelintResult = require('./createPartialStylelintResult'); | |||
There was a problem hiding this comment.
I don't love this name, but it's only used internally. It should be easy enough to change later 🤷
14 tasks
mattxwang
approved these changes
Jun 2, 2020
m-allanson
added a commit
that referenced
this pull request
Jun 3, 2020
# By Mike Allanson (6) and others # Via GitHub * master: Bump @types/lodash from 4.14.152 to 4.14.154 (#4817) Update CHANGELOG.md Fix with workaround a TypeError thrown for "html" (#4797) Update CHANGELOG.md Fix false positives for variables in font-family-no-missing-generic-family-keyword (#4806) Update CHANGELOG.md Add ignoreSelectors option to block-opening-brace-space-before (#4640) Update CHANGELOG.md Fix error message percentage/number precision for alpha-value-notation (#4802) Create new 'createPartialStylelintResult' module (#4815) Move function normalizeAllRuleSettings() out to a separate module (#4810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future PR this module will be required by the new browser.js module. This change has been extracted from: #4796
Related to issue #3935
This change is a small part of the changes in PR #4796