Fix false positives for variables in font-family-no-missing-generic-family-keyword #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a second parse loop through a font-family. To avoid this, we could add an parameter to findFontFamily which dictates whether to include variables in the result, but the function would need to blindly include variables, without sanity checking them (like whether a variable represents a number or something). Fixes stylelint#4765
mattxwang
reviewed
May 30, 2020
There was a problem hiding this comment.
Overall this looks good to me, and it passes the test case mentioned in the spec.
Would like to get other opinions before giving the go-ahead to merge - like on the discussion point on the second parse loop, or if there are any other test cases we should consider.
jeddy3
approved these changes
May 31, 2020
jeddy3
changed the title
|
Updated changelog:
|
m-allanson
added a commit
that referenced
this pull request
Jun 3, 2020
# By Mike Allanson (6) and others # Via GitHub * master: Bump @types/lodash from 4.14.152 to 4.14.154 (#4817) Update CHANGELOG.md Fix with workaround a TypeError thrown for "html" (#4797) Update CHANGELOG.md Fix false positives for variables in font-family-no-missing-generic-family-keyword (#4806) Update CHANGELOG.md Add ignoreSelectors option to block-opening-brace-space-before (#4640) Update CHANGELOG.md Fix error message percentage/number precision for alpha-value-notation (#4802) Create new 'createPartialStylelintResult' module (#4815) Move function normalizeAllRuleSettings() out to a separate module (#4810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4765
Yes, this introduces a second parse loop through a font-family.
To avoid this, we could add an parameter to findFontFamily which
dictates whether to include variables in the result, but the function
would need to blindly include variables, without sanity checking them
(like whether a variable represents a number or something).