Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for all scope disables in --report-invalid-scope-disables #4784

Merged
merged 1 commit into from Jun 3, 2020
Merged

Fix false positives for all scope disables in --report-invalid-scope-disables #4784

merged 1 commit into from Jun 3, 2020

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

Closes #4717

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

mattxwang
mattxwang approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@m-allanson m-allanson merged commit 6a043ae into master Jun 3, 2020
@m-allanson m-allanson deleted the issue-4717 branch June 3, 2020 19:58
@m-allanson
Copy link
Member

Updated changelog:

  • Fixed: false positives for all scope disables in `--report-invalid-scope-disables (#4784)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for all scope disables in --report-invalid-scope-disables.
4 participants
@ota-meshi @m-allanson @jeddy3 @mattxwang