Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for forced-colors in media-feature-name-* rules #4775

Merged
merged 1 commit into from May 16, 2020
Merged

Fix false positives for forced-colors in media-feature-name-* rules #4775

merged 1 commit into from May 16, 2020

Conversation

mathiasbynens
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #4773.

Is there anything in the PR that needs further explanation?

jeddy3
jeddy3 approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

@jeddy3 jeddy3 changed the title Add forced-colors support for media-feature-name-* rules Fix false positives for forced-colors in media-feature-name-* rules May 15, 2020
ybiquitous
ybiquitous approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

By the way, it seems that the following URLs should be updated:

stylelint/lib/reference/keywordSets.js

Line 554 in cca7d52

// https://drafts.csswg.org/mediaqueries/#descdef-media-update

stylelint/lib/reference/keywordSets.js

Line 567 in cca7d52

// https://drafts.csswg.org/mediaqueries/#descdef-media-update 

-https://drafts.csswg.org/mediaqueries/
+https://drafts.csswg.org/mediaqueries-5/

The former is for Media Queries Level 4, and the latter is for Media Queries Level 5.

@mathiasbynens
Copy link
Contributor Author

mathiasbynens commented May 15, 2020 •
edited 

-https://drafts.csswg.org/mediaqueries/
+https://drafts.csswg.org/mediaqueries-5/

The former is for Media Queries Level 4, and the latter is for Media Queries Level 5.

I think the former is just the permanent link to whatever the latest draft is. The latter is a fixed snapshot for level 5, like how https://drafts.csswg.org/mediaqueries-4/ is a fixed snapshot for level 4. @argyleink and @una can probably clarify if this is correct. IMHO we should continue pointing to the latest draft, since that's what browsers strive to implement.

@ybiquitous
Copy link
Member

@mathiasbynens That makes sense. Thank you for your detailed explanation! 🥰

@jeddy3 jeddy3 merged commit 9639066 into stylelint:master May 16, 2020
@jeddy3
Copy link
Member

jeddy3 commented May 16, 2020

Changelog entry:

  • Fixed: media-feature-name-* false positives for forced-colors (#4775).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix support for forced-colors in media-feature-name-*
3 participants
@mathiasbynens @ybiquitous @jeddy3