Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives regression for mixed-case ignoreProperties in value-keyword-case #4748

Merged
merged 1 commit into from May 12, 2020
Merged

Fix false positives regression for mixed-case ignoreProperties in value-keyword-case #4748

merged 1 commit into from May 12, 2020

Conversation

srawlins
Copy link
Contributor

@srawlins srawlins commented May 6, 2020

Which issue, if any, is this issue related to?

Fixes #4644

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the pull requests and squishing these bugs!

Looks good to me.

@jeddy3 jeddy3 changed the title value-keyword-case: compare ignoreProperty list with original property name Fix false positives regression for mixed-case ignoreProperties in value-keyword-case May 12, 2020
m-allanson
m-allanson approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @srawlins.

@jeddy3 jeddy3 merged commit 0b59133 into stylelint:master May 12, 2020
@jeddy3
Copy link
Member

jeddy3 commented May 12, 2020

Changelog:

  • Fixed: value-keyword-case false positives regression for mixed-case properties and the ignoreProperties option (#4748).

@srawlins srawlins deleted the fix-4644 branch May 13, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-allanson m-allanson m-allanson approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives regression for mixed-case ignoreProperties in value-keyword-case
3 participants
@srawlins @jeddy3 @m-allanson